Added CacheInterface stub #236
Conversation
|
The However, in this case the callback actually optionally accepts Also, the parameter is annotated as Finally, please add some tests. |
| /** | ||
| * @template T | ||
| * | ||
| * @param \Symfony\Contracts\Cache\CallbackInterface<T>|callable(\Psr\Cache\CacheItemInterface): T $callback |
There was a problem hiding this comment.
\Psr\Cache\CacheItemInterface=, notice the = at the end. See https://phpstan.org/writing-php-code/phpdoc-types#callables.
For the Parameter $callback of method Symfony\Contracts\Cache\CacheInterface::get() has invalid type Psr\Cache\CacheItemInterface. error, we need to actually add the Psr\Cache\CacheItemInterface stub as well. It should be sufficient for it to be an empty class. We only need to know the class, we don't care about methods. See https://phpstan.org/user-guide/stub-files, Why is PHPStan complaining about “Class not found” in a stub file?
There was a problem hiding this comment.
Thanks for the feedback, I was not familiar with the = optional notation, actually thought it was a typo.
|
Can you please write some tests in https://github.com/phpstan/phpstan-symfony/blob/master/tests/Type/Symfony/ExtensionTest.php to verify this signature works as expected? More info here: https://phpstan.org/developing-extensions/testing#type-inference |
| return $bar; | ||
| }; | ||
|
|
||
| assertType('Bar', $cacheInterface->get('cacheTest', $callbackCallable)); |
There was a problem hiding this comment.
The case with \Symfony\Contracts\Cache\CallbackInterface<T> should also be tested.
|
Thank you. |
3 participants
Closes #235